[PoC] GUI: Migrate BIP70 merchant info to mapValue["to"] #15064
Conversation
| } | ||
| return {}; | ||
| } | ||
| bool writeWalletTxValues(const uint256& txid, std::map<std::string, std::string> new_map) |
There was a problem hiding this comment.
Should be marked override?
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
Unsure about this... what is the long term use case for the stored data? Would it eventually be more straight forward to give steps how to keep the BIP70 data in a release notes (once completely removed)? |
|
The BIP70 stuff is currently stored in a protobuf-encoded format IIRC, so accessing it post-removal or even from RPC would be invasive. |
|
I think this makes some sense in context of deprecating BIP70. The data should remain in the wallet (for legal/historical purposes) but will effectively become inaccessible. |
| Needs rebase |
|
closing in favor of #16852 (if it works) |
The idea being to save this information in a usable format before we remove BIP70 entirely...
Thoughts?