Add BIP16 to consensus params for consistency #11430
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c374eff to
d75692c
Compare
ryanofsky
reviewed
Oct 2, 2017
Contributor
ryanofsky
left a comment
There was a problem hiding this comment.
utACK d75692cecba1e834c598734703a5634549f19159 as long as misleading comment about block heights is fixed.
src/consensus/params.h
Outdated
Contributor
There was a problem hiding this comment.
Comment is misleading because because the BIP16 value is not a block height. Should clarify the comment, or maybe change the type of the array.
d75692c to
eededab
Compare
Contributor
Author
|
Decoupled from #11426 (solves @ryanofsky 's nit). |
eededab to
21083c7
Compare
Contributor
Author
|
Closing in favor of #11389 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not only regtest could activate bip16 earlier than 1333238400 (aka Apr 1 2012), but also altchains rebasing on top of bitcoin core could activate it from the beginning of time (aka time 0, long before 1970's epoch and height=0 because bip16 was faulty in using time instead of height, but it is fine to "abuse" uint32_t for 2 purposes here).
Depencies:- [ ] BIP90: Make buried deployments slightly more easily extensible #11426