Enable devirtualization opportunities by using the final specifier (C++11) #10847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
See also #10809
|
…++11) * Declaring CCoinsViewErrorCatcher final enables devirtualization of two calls * Declaring CReserveKey final enables devirtualization of one call
e1c4eb4 to
db53d98
Compare
Contributor
Author
Contributor
|
utACK db53d98 |
Member
|
Can we try to do this in one go with #10809? Seems nonsense to have multiple PRs open for this. |
Contributor
Author
|
@laanwj Makes sense - closing! :-) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable devirtualization opportunities by using the
finalspecifier (C++11).CCoinsViewErrorCatcherfinal enables devirtualization of two callsCReserveKeyfinal enables devirtualization of one call