Opening this to track the potential followups, mentioned by @real-or-random, after the libsecp256k1 update in #19228.

If we do those two changes (the second change belonging to this repo), we will have a clean copy of ecdsa_signature_parse_der_lax again. But maybe this is non-trivial enough to go to a second PR. I'm volunteering to open a PR after I digged through all the stuff now.

comment:

@real-or-random Thanks for pointing that out. I added a commit to rename privkey to seckey in key.cpp (as a scripted diff). I've left the DER parsing code be for now, as it seems unclear what changes to address where.

comment:

I've left the DER parsing code be for now, as it seems unclear what changes to address where.

Ok, let's do this in a different PR.