Require CBlockIndex::IsValid() to hold cs_main

vasild · jonatack · commit ca47b005770f · 2022-01-25T20:43:31.000+01:00
diff --git a/src/chain.h b/src/chain.h
@@ -311,7 +311,9 @@ class CBlockIndex
 
     //! Check whether this block index entry is valid up to the passed validity level.
     bool IsValid(enum BlockStatus nUpTo = BLOCK_VALID_TRANSACTIONS) const
+        EXCLUSIVE_LOCKS_REQUIRED(::cs_main)
     {
+        AssertLockHeld(::cs_main);
         assert(!(nUpTo & ~BLOCK_VALID_MASK)); // Only validity flags allowed.
         if (nStatus & BLOCK_FAILED_MASK)
             return false;

Original file line number	Diff line number	Diff line change
`@@ -311,7 +311,9 @@ class CBlockIndex`
`311`	`311`
`312`	`312`	`//! Check whether this block index entry is valid up to the passed validity level.`
`313`	`313`	`bool IsValid(enum BlockStatus nUpTo = BLOCK_VALID_TRANSACTIONS) const`
	`314`	`+ EXCLUSIVE_LOCKS_REQUIRED(::cs_main)`
`314`	`315`	`{`
	`316`	`+ AssertLockHeld(::cs_main);`
`315`	`317`	`assert(!(nUpTo & ~BLOCK_VALID_MASK)); // Only validity flags allowed.`
`316`	`318`	`if (nStatus & BLOCK_FAILED_MASK)`
`317`	`319`	`return false;`