Remove pjos parameter from BIP77 example URI#1887
Closed
spacebear21 wants to merge 1 commit intobitcoin:masterfrom
Closed
Remove pjos parameter from BIP77 example URI#1887spacebear21 wants to merge 1 commit intobitcoin:masterfrom
pjos parameter from BIP77 example URI#1887spacebear21 wants to merge 1 commit intobitcoin:masterfrom
Conversation
The `pjos=0` parameter disables output substitution, but by default it is omitted to enable output substitution and allow use cases such as transaction cut-through. The [reference implementation](https://github.com/payjoin/rust-payjoin/blob/5839d20d67cca3a5b9d69357b8702f2d2fc24635/payjoin/src/core/receive/v2/mod.rs#L392) omits the `pjos` parameter by default.
jonatack
reviewed
Jul 1, 2025
| time](https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap04.html#tag_04_16). | ||
|
|
||
| For example, a properly encoded endpoint Bitcoin URI looks like this | ||
| `bitcoin:tb1q6q6de88mj8qkg0q5lupmpfexwnqjsr4d2gvx2p?amount=0.00666666&pjos=0&pj=HTTPS://PAYJO.IN/TXJCGKTKXLUUZ%23RK1Q0DJS3VVDXWQQTLQ8022QGXSX7ML9PHZ6EDSF6AKEWQG758JPS2EV+OH1QYPM59NK2LXXS4890SUAXXYT25Z2VAPHP0X7YEYCJXGWAG6UG9ZU6NQ+EX1WKV8CEC` |
Member
There was a problem hiding this comment.
Seems reasonable, pinging BIP authors @DanGould @nothingmuch for feedback
Contributor
There was a problem hiding this comment.
I believe this is a bug in the implementation, I opened payjoin/rust-payjoin#843
Contributor
There was a problem hiding this comment.
Agreed. NACK on this change but good catch for the implementation
Member
|
Good catch @spacebear21 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
pjos=0parameter disables output substitution, but by default it is omitted to enable output substitution and allow use cases such as transaction cut-through. The reference implementation omits thepjosparameter by default.