BIP-174: Removing PSBT_OUT_TAP_LEAF_SCRIPT#1241
Merged
kallewoof merged 2 commits intobitcoin:masterfrom Jan 7, 2022
Merged
Conversation
`PSBT_OUT_TAP_LEAF_SCRIPT` seemed to appear in output key sections by copy-paste from input section. First, it shares the same byte no as `PSBT_OUT_TAP_TREE`, second its description talks about "witness"
Member
|
ACK 457e354 |
Member
|
While we're making fixups like this, can you also remove |
Contributor
|
Didn't realize this was RFM. Will wait for requested change. |
Contributor
Author
|
@achow101 sorry for taking that so long. Removed according to your suggestion |
Member
|
ACK d165229 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PSBT_OUT_TAP_LEAF_SCRIPTseemed to appear in output key sections by copy-paste from input section. First, it shares the same byte no asPSBT_OUT_TAP_TREE, second its description talks about "witness"