implemented redux-logger given an environmental variable#61
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #61 +/- ##
==========================================
+ Coverage 80.64% 80.66% +0.01%
==========================================
Files 36 36
Lines 806 812 +6
Branches 99 100 +1
==========================================
+ Hits 650 655 +5
- Misses 156 157 +1
Continue to review full report at Codecov.
|
thejmazz
approved these changes
Jul 7, 2017
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR implemented a check for an environmental variable that changes the middlewares within
lib/watermill.js. IfREDUX_LOGGER=1in environment the pipeline will executeredux-logger.Also redux-logger package was updated in this PR.