Updated docker related links and added link to tutorial in README#56
Updated docker related links and added link to tutorial in README#56thejmazz merged 6 commits intobionode:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #56 +/- ##
=======================================
Coverage 80.64% 80.64%
=======================================
Files 36 36
Lines 806 806
Branches 99 99
=======================================
Hits 650 650
Misses 156 156Continue to review full report at Codecov.
|
|
Added tutorial and blog entry about work-flow managers to main README.md. You can now check it and see if everything is ok and if so merge it. However, note that issue 49 should also address the creation of tasks with js functions and streams. |
|
Added a way to create a manifest file that allow to make a correspondence between folders created within |
lib/sagas/lifecycle.js
Outdated
| // First handles the possibility of input, output and params being an | ||
| // object rather than a string (e.g. when multiple params are passed to | ||
| // the task). | ||
| let string_output = JSON.stringify(originalTask.output) |
lib/sagas/lifecycle.js
Outdated
| let string_params = JSON.stringify(originalTask.params) | ||
| // Then creates the string to be written to the log file | ||
| let manifest_log = | ||
| `{ folder_name: "${originalTask.dir}", |
There was a problem hiding this comment.
this should just be an object that you stringify
lib/sagas/lifecycle.js
Outdated
| output: ${string_output}, | ||
| params: ${string_params} }\n` | ||
| // Writes to the file | ||
| fs.appendFile('summary_log.txt', manifest_log, function (err) { |
There was a problem hiding this comment.
maybe logfile should be ndjson (one json object per line)
|
I have separated the tutorial updates from the summary log file commits, in order to simplify the revision. So, if you feel this is ok, please feel free to merge. |
Performed the updates described in the title.