Merged
Conversation
bmpvieira
requested changes
Aug 23, 2017
Member
bmpvieira
left a comment
There was a problem hiding this comment.
Looks good, just needs two small changes.
lib/index.js
Outdated
|
|
||
|
|
||
| if (line.indexOf('#') === 0) { | ||
| // ##fileformat=VCFv4.1 |
Member
There was a problem hiding this comment.
Can you please fix the indentation of the comments here and below?
package.json
Outdated
| "main": "lib/index.js", | ||
| "scripts": { | ||
| "test": "mocha" | ||
| "test": "standard && dependency-check ." |
Member
There was a problem hiding this comment.
You should keep the mocha testing here, like standard && dependency-check . && mocha
Member
Author
|
These two commits should handle your concerns. Unless I got the indentation wrong... |
bmpvieira
approved these changes
Aug 28, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation standardizations, better "Standard JS" conformance, bumped package versions and implemented "Standard JS" tests.