Merged
Conversation
bmpvieira
requested changes
Aug 23, 2017
Member
bmpvieira
left a comment
There was a problem hiding this comment.
Just need to keep mocha in tests
package.json
Outdated
| "scripts": { | ||
| "preinstall": "sam/build.sh", | ||
| "test": "mocha --reporter spec", | ||
| "test": "standard && dependency-check .", |
Member
There was a problem hiding this comment.
Please keep mocha here after the other tests.
Member
Author
|
Added the |
Member
|
Sorry, I didn't see that tests were still missing. I'll merge your changes anyway and someone can add tests later. |
bmpvieira
approved these changes
Aug 28, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added CONTRIBUTING.md, standardized README.md, improved "Standard JS" conformance, bumped package versions, removed spammy notifications and removed unimplemented tests. Fixes #5 .