Skip to content

Added a .travis.yml file.#3

Merged
thejmazz merged 4 commits intomasterfrom
travis_yml
Oct 4, 2017
Merged

Added a .travis.yml file.#3
thejmazz merged 4 commits intomasterfrom
travis_yml

Conversation

@StuntsPT
Copy link
Member

@StuntsPT StuntsPT commented Jun 3, 2017

As per the title. Fixes #2

@bmpvieira
Copy link
Member

No tests for Travis to run. You could add dependency-check && standard to the package.json

@StuntsPT
Copy link
Member Author

So I have added the tests, and solved most of the issues that were revealed.
However, I fear that by removing the offending lines some code will break, eg.
lib/constants.js:6:7: 'BASE_URL' is assigned a value but never used.
BASE_URL is never used in constants.js, but is used in retrieve.js like so: const { BASE_URL } = require('./constants.js')

@bmpvieira bmpvieira requested review from thejmazz and removed request for bmpvieira October 4, 2017 11:38
@thejmazz thejmazz merged commit e8bc8ab into master Oct 4, 2017
@thejmazz thejmazz deleted the travis_yml branch October 4, 2017 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants