Skip to content

fix(useVueValidVBind): don't flag missing arguments#9643

Merged
dyc3 merged 3 commits into
mainfrom
dyc3/fix-valid-v-bind
Mar 28, 2026
Merged

fix(useVueValidVBind): don't flag missing arguments#9643
dyc3 merged 3 commits into
mainfrom
dyc3/fix-valid-v-bind

Conversation

@dyc3

@dyc3 dyc3 commented Mar 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

Pretty simple fix. The v-bind without argument is valid because you can put an object as the value and it will spread the props. Its like <Foo {...props}> in jsx.

generated with gpt 5.4

fixes #9347

Test Plan

snapshots

Docs

@changeset-bot

changeset-bot Bot commented Mar 28, 2026 •
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 956001a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@biomejs/biome Patch
@biomejs/cli-win32-x64 Patch
@biomejs/cli-win32-arm64 Patch
@biomejs/cli-darwin-x64 Patch
@biomejs/cli-darwin-arm64 Patch
@biomejs/cli-linux-x64 Patch
@biomejs/cli-linux-arm64 Patch
@biomejs/cli-linux-x64-musl Patch
@biomejs/cli-linux-arm64-musl Patch
@biomejs/wasm-web Patch
@biomejs/wasm-bundler Patch
@biomejs/wasm-nodejs Patch
@biomejs/backend-jsonrpc Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added A-Linter Area: linter L-HTML Language: HTML and super languages labels Mar 28, 2026
@coderabbitai

coderabbitai Bot commented Mar 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b2a0f9f5-16c2-4f32-94af-012e65b6e7ce

📥 Commits

Reviewing files that changed from the base of the PR and between cddfb44 and 956001a.

⛔ Files ignored due to path filters (2)
  • packages/@biomejs/backend-jsonrpc/src/workspace.ts is excluded by !**/backend-jsonrpc/src/workspace.ts and included by **
  • packages/@biomejs/biome/configuration_schema.json is excluded by !**/configuration_schema.json and included by **
📒 Files selected for processing (1)
  • .changeset/happy-apples-feel.md
✅ Files skipped from review due to trivial changes (1)
  • .changeset/happy-apples-feel.md

Walkthrough

This PR updates the useVueValidVBind Vue linter rule: it removes the MissingArgument violation and the logic that detected missing directive arguments, retains checks for missing values and invalid modifiers, updates diagnostics accordingly, and adjusts tests to drop missing-argument cases while adding valid object-style v-bind="props" fixtures.

Possibly related PRs

Suggested labels

A-Diagnostic

Suggested reviewers

  • ematipico
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: removing the incorrect flag for missing v-bind arguments, which is the core objective of the PR.
Description check ✅ Passed The description clearly explains the motivation (v-bind without argument is valid for spreading props) and links to issue #9347, directly relating to the changeset.
Linked Issues check ✅ Passed The PR fully addresses issue #9347 by modifying the rule to accept v-bind="props" and removing the MissingArgument violation kind, with corresponding test updates.
Out of Scope Changes check ✅ Passed All changes are tightly scoped to the useVueValidVBind rule implementation and its tests, with no extraneous modifications beyond fixing the reported issue.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dyc3/fix-valid-v-bind

Comment @coderabbitai help to get the list of available commands and usage tips.

@codspeed-hq

codspeed-hq Bot commented Mar 28, 2026 •
edited
Loading

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 67 untouched benchmarks
⏩ 161 skipped benchmarks1

Comparing dyc3/fix-valid-v-bind (956001a) with main (1dd4a56)

Open in CodSpeed

Footnotes

  1. 161 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

ematipico
ematipico approved these changes Mar 28, 2026
View reviewed changes
Comment thread .changeset/happy-apples-feel.md
@dyc3 @ematipico
Update .changeset/happy-apples-feel.md
956001a 
Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
@dyc3 dyc3 merged commit 5bfee36 into main Mar 28, 2026
19 checks passed
@dyc3 dyc3 deleted the dyc3/fix-valid-v-bind branch March 28, 2026 23:30
@github-actions github-actions Bot mentioned this pull request Mar 28, 2026
Merged
@coderabbitai coderabbitai Bot mentioned this pull request Mar 29, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ematipico ematipico ematipico approved these changes

Assignees

No one assigned

Labels

A-Linter Area: linter L-HTML Language: HTML and super languages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

💅 useVueValidVBind incorrectly flags v-bind="props"

2 participants

@dyc3 @ematipico