fix(file_handler): svelte & vue script language parsing#2317
Merged
Conversation
✅ Deploy Preview for biomejs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ematipico
approved these changes
Apr 5, 2024
ematipico
left a comment
Member
There was a problem hiding this comment.
I must admit, that was a very clever solution :)
| /// We use the JSX parser at the moment to parse the opening tag. So the opening tag should be first | ||
| /// matched by regular expressions. | ||
| /// | ||
| /// TODO: We should change the parser when HTMLish languages are supported. |
Member
There was a problem hiding this comment.
Suggested change
| /// TODO: We should change the parser when HTMLish languages are supported. | |
| // TODO: We should change the parser when HTMLish languages are supported. |
The TODO shouldn't be a doc comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use the JSX flavor JavaScript parser to parse the opening tags of the script blocks in Svelte and Vue files so we can parse the language of the script in them more reliably.
Closes #2245.
Test Plan
Test cases are added.