Skip to content

chore: some improvements#10050

Merged
dyc3 merged 1 commit into
biomejs:mainfrom
Netail:chore/some-improvements
Apr 19, 2026
Merged

chore: some improvements#10050
dyc3 merged 1 commit into
biomejs:mainfrom
Netail:chore/some-improvements

Conversation

@Netail

@Netail Netail commented Apr 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Summary

Some typos, use helper functions & remove test-case which isn't used and shouldn't be in valid to begin with

Test Plan

Docs

@changeset-bot

changeset-bot Bot commented Apr 19, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 8dc0960

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions Bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Apr 19, 2026
@coderabbitai

coderabbitai Bot commented Apr 19, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

This PR addresses several ARIA-related housekeeping items: fixing typos in metadata build scripts (Retuurns → Returns, aria_abstarct_role_enum → aria_abstract_role_enum), updating the role resolution logic in the use_aria_props_supported_by_role lint rule to use the new ctx.aria_roles().get_role_by_element_name() API, refining null/undefined attribute value detection, removing an obsolete commented test case, and correcting a typo in the aria-data README.

Possibly related PRs

Suggested labels

A-Linter, L-JavaScript

Suggested reviewers

  • dyc3
  • ematipico
🚥 Pre-merge checks | ✅ 1 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title is vague and non-descriptive; 'some improvements' doesn't convey what was actually changed. Use a more descriptive title that summarizes the main changes, such as 'fix: correct ARIA role generation and typos' or similar.
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The description is related to the changeset, mentioning typos, helper functions, and test case removal.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]
coderabbitai Bot reviewed Apr 19, 2026
View reviewed changes

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents 
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@crates/biome_js_analyze/src/lint/a11y/use_aria_props_supported_by_role.rs`:
- Around line 80-83: Add snapshot tests covering the new null/undefined
detection behavior introduced in use_aria_props_supported_by_role (the code path
using attribute.as_static_value().is_some_and(|static_value|
static_value.is_null_or_undefined())). Create tests in
tests/specs/<group>/use_aria_props_supported_by_role/ with both valid and
invalid snapshot files that explicitly include elements where ARIA attributes
are set to null and undefined (not just string literals) so the rule's changed
behavior is asserted; name the snapshots to show null vs undefined cases and run
the existing test harness to record expected outputs.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 41347f1f-78bd-4670-acb1-a8f9281ca9ad

📥 Commits

Reviewing files that changed from the base of the PR and between 2bc77bd and 8dc0960.

⛔ Files ignored due to path filters (1)
  • crates/biome_js_analyze/tests/specs/a11y/noInteractiveElementToNoninteractiveRole/valid.jsx.snap is excluded by !**/*.snap and included by **
📒 Files selected for processing (4)
  • crates/biome_aria_metadata/build.rs
  • crates/biome_js_analyze/src/lint/a11y/use_aria_props_supported_by_role.rs
  • crates/biome_js_analyze/tests/specs/a11y/noInteractiveElementToNoninteractiveRole/valid.jsx
  • packages/aria-data/README.md
💤 Files with no reviewable changes (1)
  • crates/biome_js_analyze/tests/specs/a11y/noInteractiveElementToNoninteractiveRole/valid.jsx

Comment thread crates/biome_js_analyze/src/lint/a11y/use_aria_props_supported_by_role.rs
@codspeed-hq

codspeed-hq Bot commented Apr 19, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 58 untouched benchmarks
⏩ 196 skipped benchmarks1

Comparing Netail:chore/some-improvements (8dc0960) with main (2bc77bd)

Open in CodSpeed

Footnotes

  1. 196 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@dyc3 dyc3 merged commit 28e37d7 into biomejs:main Apr 19, 2026
32 checks passed
@Netail Netail deleted the chore/some-improvements branch April 19, 2026 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@dyc3 dyc3 dyc3 approved these changes

Assignees

No one assigned

Labels

A-Linter Area: linter L-JavaScript Language: JavaScript and super languages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Netail @dyc3