Skip to content

💅 Svelte store dollar syntax unsupported #6316

@arnolicious

Description

@arnolicious

Environment information

CLI:
  Version:                      2.0.0-beta.6
  Color support:                true

Platform:
  CPU Architecture:             x86_64
  OS:                           windows

Environment:
  BIOME_LOG_PATH:               unset
  BIOME_LOG_PREFIX_NAME:        unset
  BIOME_CONFIG_PATH:            unset
  BIOME_THREADS:                unset
  NO_COLOR:                     unset
  TERM:                         unset
  JS_RUNTIME_VERSION:           v22.16.0
  JS_RUNTIME_NAME:              node
  NODE_PACKAGE_MANAGER:         npm/10.9.2

Biome Configuration:
  Status:                       Loaded successfully
  Path:                         biome.json
  Formatter enabled:            true
  Linter enabled:               true
  Assist enabled:               true
  VCS enabled:                  false

Linter:
  JavaScript enabled:           unset
  JSON enabled:                 unset
  CSS enabled:                  unset
  GraphQL enabled:              unset
  Recommended:                  false
  Enabled rules:
    complexity/noAdjacentSpacesInRegex
    complexity/noExtraBooleanCast
    complexity/noForEach
    complexity/noStaticOnlyClass
    complexity/noUselessCatch
    complexity/noUselessEscapeInRegex
    complexity/noUselessSwitchCase
    complexity/noUselessThisAlias
    complexity/noUselessTypeConstraint
    complexity/useDateNow
    complexity/useFlatMap
    correctness/noConstAssign
    correctness/noConstantCondition
    correctness/noEmptyCharacterClassInRegex
    correctness/noEmptyPattern
    correctness/noGlobalObjectCalls
    correctness/noInvalidBuiltinInstantiation
    correctness/noInvalidConstructorSuper
    correctness/noNonoctalDecimalEscape
    correctness/noPrecisionLoss
    correctness/noSelfAssign
    correctness/noSetterReturn
    correctness/noSwitchDeclarations
    correctness/noUndeclaredVariables
    correctness/noUnreachable
    correctness/noUnreachableSuper
    correctness/noUnsafeFinally
    correctness/noUnsafeOptionalChaining
    correctness/noUnusedLabels
    correctness/noUnusedPrivateClassMembers
    correctness/useIsNan
    correctness/useValidForDirection
    correctness/useValidTypeof
    correctness/useYield
    style/noCommonJs
    style/noNamespace
    style/noSubstr
    style/useArrayLiterals
    style/useAsConstAssertion
    style/useAtIndex
    style/useCollapsedIf
    style/useExplicitLengthCheck
    style/useFilenamingConvention
    style/useForOf
    style/useNodejsImportProtocol
    style/useNumberNamespace
    style/useThrowNewError
    style/useTrimStartEnd
    suspicious/noAssignInExpressions
    suspicious/noAsyncPromiseExecutor
    suspicious/noCatchAssign
    suspicious/noClassAssign
    suspicious/noCompareNegZero
    suspicious/noControlCharactersInRegex
    suspicious/noDebugger
    suspicious/noDocumentCookie
    suspicious/noDuplicateCase
    suspicious/noDuplicateClassMembers
    suspicious/noDuplicateElseIf
    suspicious/noDuplicateObjectKeys
    suspicious/noDuplicateParameters
    suspicious/noEmptyBlockStatements
    suspicious/noExplicitAny
    suspicious/noExtraNonNullAssertion
    suspicious/noFallthroughSwitchClause
    suspicious/noFunctionAssign
    suspicious/noGlobalAssign
    suspicious/noImportAssign
    suspicious/noIrregularWhitespace
    suspicious/noMisleadingCharacterClass
    suspicious/noMisleadingInstantiator
    suspicious/noPrototypeBuiltins
    suspicious/noRedeclare
    suspicious/noShadowRestrictedNames
    suspicious/noSparseArray
    suspicious/noThenProperty
    suspicious/noUnsafeDeclarationMerging
    suspicious/noUnsafeNegation
    suspicious/noWith
    suspicious/useErrorMessage
    suspicious/useGetterReturn
    suspicious/useNamespaceKeyword
    suspicious/useNumberToFixedDigitsArgument

Workspace:
  Open Documents:               0

Rule name

lint/correctness/noUndeclaredVariables

Playground link

immich-app/immich#19145

Expected result

Any instances of a svelte store that is being accessed with the $ syntax gets flagged as an undeclared variable.

src\lib\components\admin-page\jobs\jobs-panel.svelte:132:20 lint/correctness/noUndeclaredVariables ━━━━━━━━━━━━━━━━━

  × The $t variable is undeclared.

    130 │       subtitle: $t('admin.video_conversion_job_description'),
    131 │       allText: $t('all'),
  > 132 │       missingText: $t('missing'),
        │                    ^^
    133 │     },
    134 │     [JobName.StorageTemplateMigration]: {

This currently seems like th main cause of false positives over at https://github.com/immich-app/immich , where we're trying out alternatives to eslint :)

Code of Conduct

  • I agree to follow Biome's Code of Conduct

Metadata

Metadata

Assignees

Labels

L-JavaScriptLanguage: JavaScript and super languagesS-Bug-confirmedStatus: report has been confirmed as a valid bug

Type

No fields configured for Bug.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions