fix(useVueValidVBind): trim trivia when checking modifier-token text

otkrickey · otkrickey · commit 726fbd59475b · 2026-06-26T18:21:49.000+09:00
`find_invalid_modifiers` compared `modifier_token().text()` directly,
which includes trailing trivia. When a modifier was followed by `=value`
the trivia was empty so this happened to work; with the Vue 3.4+
same-name shorthand the modifier can now be followed by whitespace and
the self-closing `/&gt;` instead, in which case `text()` returned e.g.
`"prop "` (with the trailing space) and the valid modifier was
mis-flagged as invalid.

Switch to `text_trimmed()`, matching how the sibling rule
`no_vue_v_on_number_values` already compares modifier names. Add test
cases covering shorthand + modifier and shorthand inside a v-for.
diff --git a/crates/biome_html_analyze/src/lint/correctness/use_vue_valid_v_bind.rs b/crates/biome_html_analyze/src/lint/correctness/use_vue_valid_v_bind.rs
@@ -139,7 +139,7 @@ impl Rule for UseVueValidVBind {
 
 fn find_invalid_modifiers(modifiers: &VueModifierList) -> Option<TextRange> {
     for modifier in modifiers {
-        if !VALID_MODIFIERS.contains(&modifier.modifier_token().ok()?.text()) {
+        if !VALID_MODIFIERS.contains(&modifier.modifier_token().ok()?.text_trimmed()) {
             return Some(modifier.range());
         }
     }
diff --git a/crates/biome_html_analyze/tests/specs/correctness/useVueValidVBind/valid.vue b/crates/biome_html_analyze/tests/specs/correctness/useVueValidVBind/valid.vue
@@ -14,6 +14,13 @@
 <Foo v-bind:foo />
 <Foo v-bind:foo-bar />
 
+<!-- Same-name shorthand combined with valid modifiers. -->
+<Foo :foo.prop />
+<Foo v-bind:foo.prop />
+
+<!-- Same-name shorthand referencing a v-for iteration variable. -->
+<Foo v-for="foo of foos" :key="foo.id" :foo />
+
 <!-- Valid modifiers from the rule: prop, camel, sync, attr -->
 <div v-bind:foo.prop="bar"></div>
 <div v-bind:foo.camel="bar"></div>
diff --git a/crates/biome_html_analyze/tests/specs/correctness/useVueValidVBind/valid.vue.snap b/crates/biome_html_analyze/tests/specs/correctness/useVueValidVBind/valid.vue.snap
@@ -20,6 +20,13 @@ expression: valid.vue
 <Foo v-bind:foo />
 <Foo v-bind:foo-bar />
 
+<!-- Same-name shorthand combined with valid modifiers. -->
+<Foo :foo.prop />
+<Foo v-bind:foo.prop />
+
+<!-- Same-name shorthand referencing a v-for iteration variable. -->
+<Foo v-for="foo of foos" :key="foo.id" :foo />
+
 <!-- Valid modifiers from the rule: prop, camel, sync, attr -->
 <div v-bind:foo.prop="bar"></div>
 <div v-bind:foo.camel="bar"></div>

Original file line number	Diff line number	Diff line change
`@@ -139,7 +139,7 @@ impl Rule for UseVueValidVBind {`
`139`	`139`
`140`	`140`	`fn find_invalid_modifiers(modifiers: &VueModifierList) -> Option<TextRange> {`
`141`	`141`	`for modifier in modifiers {`
`142`		`- if !VALID_MODIFIERS.contains(&modifier.modifier_token().ok()?.text()) {`
	`142`	`+ if !VALID_MODIFIERS.contains(&modifier.modifier_token().ok()?.text_trimmed()) {`
`143`	`143`	`return Some(modifier.range());`
`144`	`144`	`}`
`145`	`145`	`}`