fix(lsp): handle navigation result errors (#10701)

ematipico · autofix-ci[bot] · web-flow · commit 6c2e0d7bba1c · 2026-06-22T06:30:33.000+01:00
Co-authored-by: autofix-ci[bot] &lt;114827586+autofix-ci[bot]@users.noreply.github.com&gt;
diff --git a/.changeset/spotty-swans-mix.md b/.changeset/spotty-swans-mix.md
@@ -0,0 +1,5 @@
+---
+"@biomejs/biome": patch
+---
+
+Fixed [#10694](https://github.com/biomejs/biome/issues/10694). The Biome Language Server no longer prints an error when the user hovers a variable imported from node_modules.
diff --git a/crates/biome_lsp/src/handlers/navigation.rs b/crates/biome_lsp/src/handlers/navigation.rs
@@ -51,7 +51,12 @@ pub(crate) fn goto_definition(
                 path: path.clone(),
                 cursor_range,
                 enabled,
-            })?;
+            });
+    // The feature might not have access to all files per design e.g. node_modules dependencies.
+    // This will return a `Result`, but we shouldn't bubble it as an error to the user.
+    let Ok(result) = result else {
+        return Ok(None);
+    };
 
     match result {
         Some(definition) => {
diff --git a/crates/biome_lsp/src/server_goto.tests.rs b/crates/biome_lsp/src/server_goto.tests.rs
@@ -742,4 +742,38 @@ async fn goto_definition_css_cross_file_multiple_definitions() -> Result<()> {
     Ok(())
 }
 
+#[tokio::test]
+async fn goto_definition_node_modules_import_does_not_error() -> Result<()> {
+    // Regression test for https://github.com/biomejs/biome/issues/10694.
+    //
+    // Line 0: `import { helper } from 'external-pkg';`
+    //          0123456789 → `helper` starts at char 9
+    let (res, _fs) = goto_definition_cross_file(CrossFileTestParams {
+        name: "goto_definition_node_modules_import_does_not_error",
+        config: r#"{ "linter": { "enabled": true } }"#,
+        files: vec![
+            (
+                "node_modules/external-pkg/index.js",
+                "export function helper() {}\n",
+            ),
+            (
+                "main.js",
+                "import { helper } from 'external-pkg';\nhelper();\n",
+            ),
+        ],
+        open_file: "main.js",
+        language_id: "javascript",
+        source: "import { helper } from 'external-pkg';\nhelper();\n",
+        cursor: pos(0, 9),
+    })
+    .await?;
+
+    assert!(
+        res.is_none(),
+        "go-to definition on a node_modules import should resolve to None, not error"
+    );
+
+    Ok(())
+}
+
 // #endregion

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +"@biomejs/biome": patch
 +---
++
 +Fixed [#10694](https://github.com/biomejs/biome/issues/10694). The Biome Language Server no longer prints an error when the user hovers a variable imported from node_modules.