Skip to content

use fast_float to read real numbers, fixes quadratic performance from sscanf#94

Merged
biojppm merged 2 commits intomasterfrom
readfloat
Nov 22, 2020
Merged

use fast_float to read real numbers, fixes quadratic performance from sscanf#94
biojppm merged 2 commits intomasterfrom
readfloat

Conversation

@biojppm
Copy link
Copy Markdown
Owner

@biojppm biojppm commented Nov 22, 2020

resolves #40

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 22, 2020

Codecov Report

Merging #94 (74df6c3) into master (9d46e61) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #94   +/-   ##
=======================================
  Coverage   93.25%   93.26%           
=======================================
  Files          59       59           
  Lines        6586     6589    +3     
=======================================
+ Hits         6142     6145    +3     
  Misses        444      444           
Impacted Files Coverage Δ
src/c4/yml/emit.hpp 100.00% <100.00%> (ø)
src/c4/yml/parse.cpp 90.89% <0.00%> (+<0.01%) ⬆️
src/c4/yml/tree.cpp 92.81% <0.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d46e61...74df6c3. Read the comment docs.

@biojppm biojppm merged commit c1ac1c0 into master Nov 22, 2020
@biojppm biojppm deleted the readfloat branch November 22, 2020 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Parsing can become accidentally quadratic because of sscanf

1 participant