Conversation
added 2 commits
November 5, 2019 15:48
Codecov Report
@@ Coverage Diff @@
## master #70 +/- ##
==========================================
+ Coverage 96.24% 96.25% +0.01%
==========================================
Files 25 25
Lines 798 802 +4
Branches 157 157
==========================================
+ Hits 768 772 +4
Misses 16 16
Partials 14 14
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While updating a demo of the Python API, I discovered that the
microhapulator.contrib.contribhas no way of processing aProfileobject already in memory. It could only take a JSON file or BAM/FASTA as input. This update fixes the API so that themicrohapulator.contrib.contribworks only onProfileobjects, and changes the CLI to accommodate all the requisite handling of input files.Any relevant issue threads are referenced in the description