Remove empty samples / features in the table after matching but before shearing#247
Merged
ElDeveloper merged 20 commits intobiocore:masterfrom Jul 10, 2020
Merged
Conversation
Closes biocore#244. Just gotta add tests for this now...
…er-empty-removal
…er-empty-removal
quiets pandas about warning
And handle this by raising an explanatory error msg. TODO, just gotta fix tests now???
one step closer to biocore#244 >:)
…er-empty-removal
Also fixed the filter_unobserved_features test by updating the metadata accordingly
had to add a noqa for a particularly long url comment also re-commented the writing-dictcode.py-out code from the core tests (my b, shouldn't have committed that)
Now that this all is mostly done, we can close biocore#244
instead, defer this to remove_empty_...(), later on. per biocore#244.
ElDeveloper
approved these changes
Jul 10, 2020
Co-authored-by: Yoshiki Vázquez Baeza <yoshiki@ucsd.edu>
Co-authored-by: Yoshiki Vázquez Baeza <yoshiki@ucsd.edu>
Co-authored-by: Yoshiki Vázquez Baeza <yoshiki@ucsd.edu>
Member
|
Thanks @ElDeveloper |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures that empty features in the table are removed from the tree if shearing is requested (could impact datasets where the user rarefied a table and this resulted in certain features having abundances of 0). Also gives a fancy error if these "empty" samples or features are present in the ordination (should probably never happen in practice, but if it does happen then the user'll know at least).
Closes #244.