Skip to content

Fix test_converter_benchmark: logger.info() incompatible with easydev Logging API#363

Merged
cokelaer merged 3 commits intomainfrom
copilot/fix-fasta2faa-tests
Mar 7, 2026
Merged

Fix test_converter_benchmark: logger.info() incompatible with easydev Logging API#363
cokelaer merged 3 commits intomainfrom
copilot/fix-fasta2faa-tests

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 6, 2026

test/scripts/test_converters.py::test_converter_benchmark was failing with exit code 1 because easydev.Logging.info() only accepts (self, msg) — it does not support printf-style variadic format arguments.

Changes

  • bioconvert/scripts/converter.py: Replace two logger.info() calls using %s format args with f-strings:
    # Before (raises: "Logging.info() takes 2 positional arguments but 3 were given")
    logger.info("File %s.png created", benchmark_tag)
    logger.info("Saved results in %s", json_file)
    
    # After
    logger.info(f"File {benchmark_tag}.png created")
    logger.info(f"Saved results in {json_file}")
  • .gitignore: Add bioconvert.json (benchmark output) to prevent accidental commits.

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

Copilot AI and others added 2 commits March 6, 2026 22:24
Co-authored-by: cokelaer <778821+cokelaer@users.noreply.github.com>
Co-authored-by: cokelaer <778821+cokelaer@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix fasta2faa and fastq2fasta test failures Fix test_converter_benchmark: logger.info() incompatible with easydev Logging API Mar 6, 2026
@cokelaer cokelaer marked this pull request as ready for review March 7, 2026 21:05
@cokelaer cokelaer merged commit c675c3b into main Mar 7, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants