This repository was archived by the owner on Dec 17, 2025. It is now read-only.
pub incorrectly consuming a field type#78
Merged
VictorKoenders merged 3 commits intotrunkfrom Jan 16, 2024
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## trunk #78 +/- ##
==========================================
+ Coverage 48.42% 49.16% +0.73%
==========================================
Files 20 20
Lines 2030 2087 +57
==========================================
+ Hits 983 1026 +43
- Misses 1047 1061 +14 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
Wife pointed out that this will not work for
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #77
Visibility::try_takehas a case where givenpub(self)it ignores the(self). It incorrectly assumedpub [u8; 2]was similar. This PR fixes it so it only ignores(...)and not[...]