This repository was archived by the owner on Dec 17, 2025. It is now read-only.
GenConst: moved into gen_const.rs#55
Merged
VictorKoenders merged 3 commits intobincode-org:trunkfrom May 16, 2023
wbcat:gen_const_pub
Merged
GenConst: moved into gen_const.rs#55VictorKoenders merged 3 commits intobincode-org:trunkfrom wbcat:gen_const_pub
VictorKoenders merged 3 commits intobincode-org:trunkfrom
wbcat:gen_const_pub
Conversation
- make_pub added - Impl.generate_const added
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## trunk #55 +/- ##
==========================================
+ Coverage 48.58% 49.72% +1.13%
==========================================
Files 19 20 +1
Lines 2019 1965 -54
==========================================
- Hits 981 977 -4
+ Misses 1038 988 -50
☔ View full report in Codecov by Sentry. |
Contributor
|
LGTM, can you rebase or merge the latest trunk? |
Contributor
Author
|
Merged the latest trunk. |
Contributor
|
Looks good to me! Sorry this took a while to merge, life has been busy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #54
new mod gen_const.rs, contains GenConst + impl, formerly residingin in impl_for.rs