This repository was archived by the owner on Dec 17, 2025. It is now read-only.
refactor: remove I from impl_for_with_lifetimes#40
Merged
VictorKoenders merged 1 commit intobincode-org:trunkfrom Mar 30, 2023
Merged
refactor: remove I from impl_for_with_lifetimes#40VictorKoenders merged 1 commit intobincode-org:trunkfrom
I from impl_for_with_lifetimes#40VictorKoenders merged 1 commit intobincode-org:trunkfrom
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## trunk #40 +/- ##
==========================================
- Coverage 39.94% 39.90% -0.05%
==========================================
Files 19 19
Lines 1860 1852 -8
==========================================
- Hits 743 739 -4
+ Misses 1117 1113 -4
... and 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Contributor
|
This is indeed a breaking change, especially if someone does That being said we're on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Igeneric is unnecessary sinceItemis an associated type and cannot be specified independently ofITER. I think this is technically a breaking change for anyone explicitly naming all the generic parameters. That said, probably nobody is doing that because these are generic for convenience and ergonomics, not explicit typing. Honestly I would probably just turn both args intoimpl Traitparams, but that may just be me.