This repository was archived by the owner on Dec 17, 2025. It is now read-only.
Merged
Conversation
fixes #36
Contributor
|
I would merge this but github actions is having a day... |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## trunk #37 +/- ##
==========================================
- Coverage 39.94% 39.90% -0.05%
==========================================
Files 19 19
Lines 1860 1852 -8
==========================================
- Hits 743 739 -4
+ Misses 1117 1113 -4
... and 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Contributor
|
If you fix the missing doc issues, I think this is good to go 👍 |
Contributor
Author
|
Docs have been added. |
VictorKoenders
approved these changes
Mar 30, 2023
Contributor
VictorKoenders
left a comment
There was a problem hiding this comment.
Thanks! This looks great
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #36