Skip to content
This repository was archived by the owner on Dec 17, 2025. It is now read-only.

AttributeAccess extension methods#2

Merged
VictorKoenders merged 5 commits intobincode-org:trunkfrom
tguichaoua:feature/attribute_access
Jan 1, 2022
Merged

AttributeAccess extension methods#2
VictorKoenders merged 5 commits intobincode-org:trunkfrom
tguichaoua:feature/attribute_access

Conversation

@tguichaoua
Copy link
Copy Markdown
Contributor

closes #1

  • Add AttributeAccess extension methods to Vec<Attribute>.
  • Remove has_attribute and get_attribute from IdentOrIndex and UnnamedField. Since their attributes field is accessible directly.

Copy link
Copy Markdown
Contributor

@VictorKoenders VictorKoenders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VictorKoenders VictorKoenders merged commit 3d68a3a into bincode-org:trunk Jan 1, 2022
@tguichaoua tguichaoua deleted the feature/attribute_access branch January 1, 2022 20:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

has/get_attribute as extension method

2 participants