This repository was archived by the owner on Aug 15, 2025. It is now read-only.
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## trunk #540 +/- ##
=======================================
Coverage 69.45% 69.46%
=======================================
Files 46 46
Lines 3179 3180 +1
=======================================
+ Hits 2208 2209 +1
Misses 971 971
Continue to review full report at Codecov.
|
19 tasks
ghost
approved these changes
May 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the list of targets being tested to match cross 0.2.1 (the current latest version). Previously the list was based on
main, and a lot of the targets simply didn't exist.Some of the targets are commented out because they simply don't build. Bincode passes all tests on all targets that successfully build.
powerpc64le-unknown-linux-gnutechnically builds but fails the test, but this is soley because of a bug in floating points on qemu, where allf32andf64values are0.0and aren't equal to each other. cross-rs/cross#644