Skip to content
This repository was archived by the owner on Aug 15, 2025. It is now read-only.

Implemented the newly stabilized CString::from_vec_with_nul method#473

Merged
VictorKoenders merged 1 commit intotrunkfrom
cstring_from_vec_with_nul
Jan 13, 2022
Merged

Implemented the newly stabilized CString::from_vec_with_nul method#473
VictorKoenders merged 1 commit intotrunkfrom
cstring_from_vec_with_nul

Conversation

@VictorKoenders
Copy link
Copy Markdown
Contributor

Closes #416

May not compile yet if github actions isn't on 1.58 yet

@VictorKoenders VictorKoenders requested a review from a user January 13, 2022 19:45
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 13, 2022

Codecov Report

Merging #473 (8d3a85b) into trunk (46b7f20) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            trunk     #473      +/-   ##
==========================================
+ Coverage   66.82%   66.84%   +0.01%     
==========================================
  Files          37       37              
  Lines        2677     2675       -2     
==========================================
- Hits         1789     1788       -1     
+ Misses        888      887       -1     
Impacted Files Coverage Δ
src/error.rs 0.00% <ø> (ø)
src/features/impl_std.rs 77.93% <100.00%> (+0.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46b7f20...8d3a85b. Read the comment docs.

@VictorKoenders VictorKoenders force-pushed the cstring_from_vec_with_nul branch from d9a2f08 to 8d3a85b Compare January 13, 2022 19:48
@VictorKoenders VictorKoenders merged commit f33abb2 into trunk Jan 13, 2022
@VictorKoenders VictorKoenders deleted the cstring_from_vec_with_nul branch January 13, 2022 19:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unblocked TODO: /rust-lang/rust/issues/73179 was closed.

2 participants