This repository was archived by the owner on Aug 15, 2025. It is now read-only.
Made the derive macros automatically implement the required traits on generic arguments#454
Merged
VictorKoenders merged 1 commit intotrunkfrom Dec 14, 2021
Merged
Conversation
… generic arguments
ghost
approved these changes
Dec 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #451
This PR builds upon a new function in
virtue:modify_generic_constraintsThe derive macros will now automatically assume any generic argument implements the required traits.
If a user is in a situation where this isn't required, a solution is:
BorrowDecode/Decode/Encodemanually#[bincode(bounds = "T: Decode")]attribute in the future to override the current type check logic, similar to https://serde.rs/container-attrs.html#bound