Skip to content
This repository was archived by the owner on Aug 15, 2025. It is now read-only.

Unignore doctests where possible#402

Closed
rukai wants to merge 1 commit intobincode-org:trunkfrom
rukai:unignore_doctests
Closed

Unignore doctests where possible#402
rukai wants to merge 1 commit intobincode-org:trunkfrom
rukai:unignore_doctests

Conversation

@rukai
Copy link

@rukai rukai commented Aug 6, 2021

closes #363

Possibly we would be better off just deleting the examples from Serializer and Deserializer?
I dont mind either way.

I left the zigzag example as ignore because its a pseudocode demonstration and getting it compiling would obscure the intent.

@stale
Copy link

stale bot commented Oct 5, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 5, 2021
@rukai rukai force-pushed the unignore_doctests branch from 9a1d2a4 to 222a7e5 Compare October 5, 2021 09:41
@stale stale bot removed the stale label Oct 5, 2021
@rukai
Copy link
Author

rukai commented Oct 5, 2021

alright, I rebased it.

@ghost
Copy link

ghost commented Oct 7, 2021

Sorry I missed this, I'll mark it as not stale for now

@VictorKoenders
Copy link
Contributor

Because we're in the middle of a big rewrite for bincode 2, I've taken the liberty to implement your change in a different PR: #421

Thank you for your contribution!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Example for Deserializer uses bytes_read method which doesn't exist

2 participants