Skip to content

Fix: wrap IPv6 addresses in tests/rtp.rs URLs in testcase.#309

Merged
a-wing merged 3 commits intobinbat:mainfrom
4627488:fix/tests_on_windows
Jul 6, 2025
Merged

Fix: wrap IPv6 addresses in tests/rtp.rs URLs in testcase.#309
a-wing merged 3 commits intobinbat:mainfrom
4627488:fix/tests_on_windows

Conversation

@4627488
Copy link
Copy Markdown
Contributor

@4627488 4627488 commented Jul 4, 2025

IPv6 literals must be surrounded by [ and ] inside a URI (RFC 3986 §3.2.2).
On Windows the tests resolve the local host to an IPv6 address, causing URL parsing to fail.

Change:

  • In helper_livetwo_rtp, introduce ip_str that brackets IpAddr::V6.
  • Replace all direct ip uses in the URL with ip_str.

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 6, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

see 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@a-wing
Copy link
Copy Markdown
Member

a-wing commented Jul 6, 2025

CLA. please. https://github.com/binbat/live777/blob/main/.github/CLA.md#list-of-contributors

@a-wing a-wing added bug Something isn't working mod::live777 Live777 server labels Jul 6, 2025
@a-wing a-wing added this to the 0.8.0 milestone Jul 6, 2025
@a-wing a-wing merged commit 05ec88d into binbat:main Jul 6, 2025
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Something isn't working mod::live777 Live777 server

Projects

None yet

Milestone

0.8.0

Development

Successfully merging this pull request may close these issues.

2 participants

@4627488 @a-wing