Skip to content

Refactor port assignment in whepfrom rtp mode#307

Merged
a-wing merged 1 commit intobinbat:mainfrom
Marsyew:main
May 23, 2025
Merged

Refactor port assignment in whepfrom rtp mode#307
a-wing merged 1 commit intobinbat:mainfrom
Marsyew:main

Conversation

@Marsyew
Copy link
Copy Markdown
Contributor

@Marsyew Marsyew commented May 23, 2025

  • Moved video/audio port assignment after codec checks
  • Set ports to None when no codec is present

- Moved video/audio port assignment after codec checks
- Set ports to None when no codec is present
@codecov
Copy link
Copy Markdown

codecov bot commented May 23, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
livetwo/src/whep.rs 80.00% 4 Missing ⚠️
Files with missing lines Coverage Δ
livetwo/src/whep.rs 86.39% <80.00%> (-0.52%) ⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@a-wing a-wing merged commit f2d549f into binbat:main May 23, 2025
7 of 8 checks passed
@a-wing a-wing added this to the 0.8.0 milestone May 23, 2025
@a-wing a-wing added mod::whepfrom whepfrom enhancement New feature or request labels May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request mod::whepfrom whepfrom

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants