Merged
Conversation
fix livetwo/utils.rs unit test error remove useless unit tests
Codecov ReportAttention: Patch coverage is
... and 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
a-wing
requested changes
May 8, 2025
| }); | ||
|
|
||
| let mut rtsp_session = RtspSession { | ||
| stream: client, |
Member
There was a problem hiding this comment.
There use type TcpStream, But there only use write_all() and read()
There can use Generics: AsyncReadExt + AsyncWriteExt. After use tokio::io::duplex create a io pair, This io working in memory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add intefration test
ffmpeg→whip_server→whep_client→whip_server→whep_server→whip_client→whep_server→ffprobe