Merged
Conversation
Codecov ReportAttention: Patch coverage is
🚀 New features to boost your workflow:
|
a-wing
requested changes
Mar 28, 2025
web/shared/api.ts
Outdated
| ) { | ||
| const wretchError = error as { response: { status: number } }; | ||
| if (wretchError.response.status === 409) { | ||
| window.alert('资源已存在，请使用不同的 streamId'); |
web/shared/api.ts
Outdated
| try { | ||
| return await w.url(`/api/streams/${streamId}?nodes=${currentNode}`).post().res(); | ||
| } catch (error: unknown) { | ||
| if ( |
Member
There was a problem hiding this comment.
Move to outside, API warp is only API, UI and window shouldn't in API warp
web/shared/api.ts
Outdated
| export async function createStream(streamId: string): Promise<unknown> { | ||
| const currentNode = getCurrentNode(); | ||
| try { | ||
| return await w.url(`/api/streams/${streamId}?nodes=${currentNode}`).post().res(); |
Member
There was a problem hiding this comment.
This is Liveman UI and Live777 UI common function, Live777 dispatcher is correct, but liveman need random dispatcher, There has problem: only dispatch nodes=0
web/shared/api.ts
Outdated
| } | ||
| export function getCurrentNode(): string { | ||
| const urlParams = new URLSearchParams(window.location.search); | ||
| return urlParams.get('nodes') || '0'; |
Member
There was a problem hiding this comment.
nodes name is set in alias = "static-0"
nodes=0 is only developer mode. https://github.com/binbat/live777/tree/main/conf/livenil
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.