Skip to content

fix:whipinto and whepfrom mode sdp file path failed at windows#247

Merged
a-wing merged 17 commits intobinbat:mainfrom
Marsyew:main
Nov 5, 2024
Merged

fix:whipinto and whepfrom mode sdp file path failed at windows#247
a-wing merged 17 commits intobinbat:mainfrom
Marsyew:main

Conversation

@Marsyew
Copy link
Copy Markdown
Contributor

@Marsyew Marsyew commented Oct 28, 2024

No description provided.

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 39.13043% with 14 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
livetwo/src/whep.rs 30.76% 6 Missing and 3 partials ⚠️
livetwo/src/whip.rs 44.44% 3 Missing and 2 partials ⚠️
Files with missing lines Coverage Δ
libs/cli/src/lib.rs 34.02% <100.00%> (+0.68%) ⬆️
tests/tests.rs 72.50% <ø> (ø)
livetwo/src/whip.rs 33.63% <44.44%> (-1.01%) ⬇️
livetwo/src/whep.rs 46.23% <30.76%> (-0.63%) ⬇️

... and 1 file with indirect coverage changes

Copy link
Copy Markdown
Member

@a-wing a-wing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#230

Remove test_liveion_stream_connect and test_liveion_stream_ffmpeg unit test #[cfg(not(windows))]


pub fn create_child(command: Option<String>) -> Result<Option<Mutex<Child>>> {
let child = if let Some(command) = command {
let command = if cfg!(windows) {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cfg! is macro!

@a-wing a-wing added bug Something isn't working mod::whipinto whipinto mod::whepfrom whepfrom labels Oct 28, 2024
@a-wing a-wing added this to the 0.7.0 milestone Nov 5, 2024
@a-wing
Copy link
Copy Markdown
Member

a-wing commented Nov 5, 2024

Fix #230

@a-wing a-wing merged commit db2184b into binbat:main Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working mod::whepfrom whepfrom mod::whipinto whipinto

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants