add whipinto/whepfrom audio support#224
Merged
a-wing merged 10 commits intobinbat:mainfrom Oct 1, 2024
Merged
Conversation
Member
WhipIntoRTPOnly videoFailed Only audioFailed Audio and Videosuccess RTSP ClientOnly videoOnly audioAudio and Video |
a-wing
reviewed
Oct 1, 2024
| pub video_rtcp_client: Option<u16>, | ||
| pub video_rtp_server: Option<u16>, | ||
| pub audio_rtp_client: Option<u16>, | ||
| pub audio_rtp_server: Option<u16>, |
libs/rtsp/src/lib.rs
Outdated
| }) | ||
| .unwrap(); | ||
|
|
||
| println!("recordrrrrr {:?}", self.media_info); |
libs/rtsp/src/lib.rs
Outdated
| fn describe(&self, req: &Request<Vec<u8>>) -> Response<Vec<u8>> { | ||
| fn describe(&mut self, req: &Request<Vec<u8>>) -> Response<Vec<u8>> { | ||
| if self.sdp.is_none() { | ||
| println!("sdp is none"); |
| /// Authentication basic to use, will be sent in the HTTP Header as 'Basic ' e.g.: admin:public | ||
| #[arg(long)] | ||
| auth_basic: Option<String>, | ||
| /// Authentication token to use, will be sent in the HTTP Header as 'Bearer ' |
Member
There was a problem hiding this comment.
Why Remove command help describe?
https://docs.rs/clap/latest/clap/_derive/_tutorial/chapter_0/index.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completed by the way #140