Command Line Entry for Check#49
Merged
pydanny merged 1 commit intobinaryornot:masterfrom Aug 10, 2019
Merged
Conversation
1b54e58 to
3970695
Compare
pombredanne
reviewed
Aug 10, 2019
Contributor
pombredanne
left a comment
There was a problem hiding this comment.
Thanks!
See my comments inline.
| def main(): | ||
| parser = argparse.ArgumentParser(description="Check if a " | ||
| "file passed as argument is " | ||
| "binary or not") |
Contributor
There was a problem hiding this comment.
What about a simpler: Check if a file is binary or not.
| parser.add_argument("filename", help="File name to check for. If " | ||
| "the file is not in the same folder, " | ||
| "include full path") | ||
|
|
Contributor
There was a problem hiding this comment.
What about using a simpler "File name or path to check."
| """ | ||
|
|
||
| import logging | ||
| import argparse |
Contributor
There was a problem hiding this comment.
What about sorting these imports?
Collaborator
There was a problem hiding this comment.
Agreed. That's a nice touch for projects.
|
|
||
| args = parser.parse_args() | ||
|
|
||
| print(is_binary(**vars(args))) |
Contributor
There was a problem hiding this comment.
This will print True or False literally, right? Is this the best way?
| coverage | ||
| tox | ||
| hypothesis | ||
| argparse No newline at end of file |
Contributor
There was a problem hiding this comment.
Why would this be needed? This is builtin since 2.7 and 3.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To use the command entry point,
python setup.py developbinaryornot filename