[R4R]Prefetch state data on mining process#803

Merged

unclezoro merged 11 commits intobnb-chain:developfrom

qinglin89:perf-prefetch-l

Mar 28, 2022

Contributor

qinglin89 commented Mar 16, 2022 •

edited

Loading

Description

When miner process mining work, there would be some hard disk access wich are quite time consuming processes.

Rationale

Add some prefetch routines to warm up touched data slots by apply transactions concurrently to the given individual state database copy.

Changes

Notable changes:

Modify Prefetch inteface so that it would be compatible with mining prefetcher
Add PrefetchMining method for state_prefetcher just like Prefetch but a mining version

Performance

The proportion of I/O overhead in mining block cost improvement.(green line represents this version)

The proportion of time delay in mining block process improvement.(green line represents this version)

qinglin89 requested review from forcodedancing, unclezoro and yutianwu

March 16, 2022 14:49


          perf(miner):add mining prefetcher

14e4f7f

qinglin89 force-pushed the perf-prefetch-l branch from 67aeba3 to 14e4f7f Compare

March 16, 2022 14:55


          fix ineffassign

411d899

unclezoro reviewed

View reviewed changes

core/gaspool.go Outdated Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

core/state_prefetcher.go Outdated Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

core/types/transaction.go Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

core/types/transaction.go Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

core/types/transaction.go Outdated Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

core/types/transaction.go Outdated Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

core/types/transaction.go Outdated Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

core/types/transaction.go Outdated Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

miner/worker.go Outdated Show resolved Hide resolved


          fix comments

ae8c772

unclezoro reviewed

View reviewed changes

core/state_prefetcher.go Outdated Show resolved Hide resolved

unclezoro changed the title ~~Prefetch state data on mining process~~ [R4R]Prefetch state data on mining process

unclezoro approved these changes

View reviewed changes

setunapo reviewed

View reviewed changes

core/gaspool.go Outdated Show resolved Hide resolved

setunapo reviewed

View reviewed changes

core/state_prefetcher.go Outdated Show resolved Hide resolved

setunapo reviewed

View reviewed changes

core/state_prefetcher.go Show resolved Hide resolved

setunapo reviewed

View reviewed changes

core/types/transaction.go Show resolved Hide resolved

setunapo reviewed

View reviewed changes

core/types/transaction.go Outdated Show resolved Hide resolved

setunapo reviewed

View reviewed changes

core/types/transaction.go Show resolved Hide resolved

setunapo reviewed

View reviewed changes

miner/worker.go Show resolved Hide resolved

setunapo reviewed

View reviewed changes

core/state_prefetcher.go Outdated Show resolved Hide resolved

Mercybudda reviewed

View reviewed changes

miner/worker.go Outdated Show resolved Hide resolved


          fix comments

efb6793

yutianwu reviewed

View reviewed changes

core/gaspool.go Outdated

               // in a block. The zero value is a pool with zero gas available.
               type GasPool uint64
+              // SetGas set an initial value for gaspool

Contributor

yutianwu Mar 24, 2022

set -> sets

Contributor Author

qinglin89 Mar 24, 2022

removed

setunapo reviewed

View reviewed changes

core/gaspool.go Outdated Show resolved Hide resolved

qinglin89 added 2 commits

March 25, 2022 01:30


          fix comments: add AsMessagePrefetch to skip nonce check

d1b701b


          fix comment:refactor check order of method Forward

bbacf02

setunapo reviewed

View reviewed changes

core/state_prefetcher.go Outdated Show resolved Hide resolved

core/state_prefetcher.go Outdated Show resolved Hide resolved

core/state_prefetcher.go Show resolved Hide resolved

core/types/transaction.go Outdated Show resolved Hide resolved

core/types/transaction.go Outdated Show resolved Hide resolved

yutianwu reviewed

View reviewed changes

core/types/transaction.go Outdated Show resolved Hide resolved

setunapo reviewed

View reviewed changes

core/types/transaction.go Outdated Show resolved Hide resolved


          fix comments:rename variables

b404d37

unclezoro suggested changes

View reviewed changes

Contributor

unclezoro left a comment

Will do review again after changes

qinglin89 added 2 commits

March 25, 2022 12:08


          fix comments: rename

27fb3fc


          rename

e3ce307

setunapo reviewed

View reviewed changes

core/types/transaction.go Show resolved Hide resolved

setunapo reviewed

View reviewed changes

core/types/transaction.go Show resolved Hide resolved

setunapo reviewed

View reviewed changes

core/types/transaction.go Show resolved Hide resolved

setunapo approved these changes

View reviewed changes

Contributor

setunapo left a comment

LGTM

unclezoro reviewed

View reviewed changes

core/types/transaction.go Show resolved Hide resolved

qinglin89 added 2 commits

March 25, 2022 15:19


          fix comments: refactor

1d3dc9a


          update

a9358a0

unclezoro approved these changes

View reviewed changes

forcodedancing approved these changes

View reviewed changes

unclezoro merged commit cbf433a into bnb-chain:develop

unclezoro pushed a commit that referenced this pull request


          [R4R]Prefetch state data on mining process (#803)

91d7cd5

* perf(miner):add mining prefetcher

* fix ineffassign

* fix comments

* fix comments

* fix comments: add AsMessagePrefetch to skip nonce check

* fix comment:refactor check order of method Forward

* fix comments:rename variables

* fix comments: rename

* rename

* fix comments: refactor

* update

This was referenced Apr 8, 2022

[R4R] prepare for release of v1.1.9 #849

Merged

[R4R] Release v1.1.9 #850

Merged

qinglin89 mentioned this pull request

[R4R]: Improve state prefetch #950

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

5 more reviewers

yutianwu yutianwu left review comments

Mercybudda Mercybudda left review comments

unclezoro unclezoro approved these changes

forcodedancing forcodedancing approved these changes

setunapo setunapo approved these changes

Labels

None yet