Skip to content

trie: reject deletions when verifying range proofs#667

Merged
keefel merged 1 commit intobnb-chain:developfrom
keefel:dev
Dec 20, 2021
Merged

trie: reject deletions when verifying range proofs#667
keefel merged 1 commit intobnb-chain:developfrom
keefel:dev

Conversation

@keefel
Copy link
Copy Markdown
Contributor

@keefel keefel commented Dec 16, 2021 •
edited
Loading

Description

Fix "panic: deletion not supported" bug, cherry-pick from ethereum/go-ethereum#23960

Rationale

Return error when range contains deletion at VerifyRangeProof, then when trie update, the deletion value won't get there, the panic won't be triggered.

Example

go test -v -run TestEmptyValueRangeProof ./trie/*.go
=== RUN   TestEmptyValueRangeProof
--- PASS: TestEmptyValueRangeProof (0.01s)

Related issues

#475
#576

This was referenced Dec 16, 2021
Closed
Closed
@unclezoro
Copy link
Copy Markdown
Contributor

unclezoro commented Dec 16, 2021

LGTM

@keefel keefel merged commit 5218949 into bnb-chain:develop Dec 20, 2021
This was referenced Jan 26, 2022
Merged
Merged
keefel added a commit to keefel/bsc that referenced this pull request Jun 6, 2022
@keefel @karalabe @j75689
trie: reject deletions when verifying range proofs (bnb-chain#667)
93d99f1 
Co-authored-by: Péter Szilágyi <peterke@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@yutianwu yutianwu yutianwu approved these changes

@unclezoro unclezoro unclezoro approved these changes

@j75689 j75689 j75689 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@keefel @unclezoro @yutianwu @j75689 @karalabe