Conversation
yutianwu
approved these changes
Jan 8, 2021
HaoyangLiu
approved these changes
Jan 11, 2021
3 tasks
pythonberg1997
pushed a commit
to pythonberg1997/bsc
that referenced
this pull request
Mar 29, 2023
…-layer-liveness imporve liveness of block proposal layer
galaio
pushed a commit
to galaio/bsc
that referenced
this pull request
Jul 31, 2024
…build ci: Fix docker build
galaio
pushed a commit
to galaio/bsc
that referenced
this pull request
Jul 31, 2024
Co-authored-by: andyzhang2023 <andyzhang2023@gmail.com> Co-authored-by: bnoieh <135800952+bnoieh@users.noreply.github.com>
j75689
pushed a commit
to j75689/bsc
that referenced
this pull request
Apr 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix the potential deadlock of pub/sub module.
More detail in: #58
Rationale
The deadlock dependency is:
Routine A:NewPendingTransactionFilter want to lock filtersMu to consume hashes;
Routine B: eventLoop is waiting Routine A to consume hashes so that it can push new hash to channel.
Routine C: Unsubscribe is holding lock filtersMu, but it is waiting for Routine B to consume uninstall channel.
Example
add an example CLI or API response...
Changes
There is no need to fetch lock on
NewPendingTransactionFilterroutine, so just loose the logic.And fix the potential risk that
Unsubscriberoutine does not drain all thehash,headerandlog.Preflight checks
make build)make test)Already reviewed by
...
Related issues