Skip to content

Add interactive check to ready event handler#1672

Merged
1cg merged 1 commit intodevfrom
dsyer-interactive-pr
Aug 4, 2023
Merged

Add interactive check to ready event handler#1672
1cg merged 1 commit intodevfrom
dsyer-interactive-pr

Conversation

@alexpetros
Copy link
Collaborator

If HTMX is imported in a module the readyState is "interactive" so the extension processing happens too late. This would fix it.

Rebased version of: #1659

If HTMX is imported in a module the readyState is "interactive"
so the extension processing happens too late. This would fix it.
@alexpetros alexpetros force-pushed the dsyer-interactive-pr branch from 08fe90b to 2244a36 Compare August 4, 2023 23:07
@1cg 1cg merged commit 347ce7a into dev Aug 4, 2023
@1cg
Copy link
Contributor

1cg commented Aug 4, 2023

awesome, thank you @alexpetros and @dsyer!

@alexpetros alexpetros deleted the dsyer-interactive-pr branch August 4, 2023 23:20
@xhaggi
Copy link
Contributor

xhaggi commented Aug 7, 2023

Does this make #1485 obsolete?

@alexpetros
Copy link
Collaborator Author

I believe so, yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants