Update same site security to use origin#1656
Merged
1cg merged 1 commit intobigskysoftware:devfrom Aug 1, 2023
adamckay:security-origin
Merged
Update same site security to use origin#16561cg merged 1 commit intobigskysoftware:devfrom adamckay:security-origin
1cg merged 1 commit intobigskysoftware:devfrom
adamckay:security-origin
Conversation
alexpetros
reviewed
Aug 1, 2023
1cg
approved these changes
Aug 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in Discord, use
originto compare whether it's the same site to have same behaviour as CSP check with protocol, hostname and port.Updated
sameHostboolean to be true if it's the same site, too.