Normalize history cache keys - redux#1338
Merged
1cg merged 3 commits intobigskysoftware:masterfrom Apr 1, 2023
Merged
Conversation
…t the fully resolved href of the boosted element matches request.detail.requestConfig.path
This was referenced Aug 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since LocalStorage is bound to the origin (domain/protocol/port triplet), we can normalize the URL format used as a key for a history snapshot to reduce cache misses for the same URL but referenced differently. E.g.: https://mysite.com/about, /about and /about/ are normalized to /about. Cache misses also mean that the scroll position of the previously visited page is lost, which can result in unexpected scroll jumps that are hard to track down.
Prevent potential key collisions in boosted relative links, by converting the href to a fully resolved root-relative path. E.g. a boosted anchor shoe.html in the directory products becomes /products/shoe.html.
As IE11 doesn't understand
URL, we silently catch the exception and return the unadulterated path. This is safer than messing about with a regex polyfill.Adjust the
boosted element hx-disinherit sanity checktest to check for the fully-resolved href of the boosted anchor.