Skip to content

Add support for minimal_valve_position parameter for Shelly Valve#503

Merged
bieniu merged 3 commits intomasterfrom
min-valve-pos
Dec 19, 2023
Merged

Add support for minimal_valve_position parameter for Shelly Valve#503
bieniu merged 3 commits intomasterfrom
min-valve-pos

Conversation

@bieniu
Copy link
Copy Markdown
Owner

@bieniu bieniu commented Nov 11, 2023

Closes #498

@bieniu bieniu added the new-feature A new feature label Nov 11, 2023
@bieniu bieniu changed the title Add support for minimum_valve_position parameter for Shelly Valve Add support for minimal_valve_position parameter for Shelly Valve Nov 11, 2023
@GergelyT
Copy link
Copy Markdown

I'd suggest the following formula if for any reason the valve goes below the minimal pos:
{{%elif value_json.thermostats.0.pos<=min_pos}%}}idle

Is this the same minimal_valve_position parameter, that was already supported ? I mean this update will not introduce the Minimal Valve Postition to Report Open parameter?

@bieniu
Copy link
Copy Markdown
Owner Author

bieniu commented Nov 12, 2023

Honestly, I don't like this change, we have to add an additional parameter, which is actually available but in a different payload. This is just stupid. That's why I opened a feature request to add valve_min_percent/valve_min_report to the payload from the info topic. We'll see what the Shelly team's response will be.

@GergelyT
Copy link
Copy Markdown

I totally understand you and if it is not a critical issue, you can cancel my request. minimal_valve_position itself was already mapped in your code and this is why I thought about stepping further. But I didn't see the issues coming from different payloads.

@bieniu
Copy link
Copy Markdown
Owner Author

bieniu commented Dec 19, 2023

No response from Shelly team so I will merge this change.

@bieniu bieniu merged commit 5cc4068 into master Dec 19, 2023
@bieniu bieniu deleted the min-valve-pos branch December 19, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TRV - Mapping valve_min_report and calculation of Idle/Heating mode

2 participants