Add support for minimal_valve_position parameter for Shelly Valve#503
Add support for minimal_valve_position parameter for Shelly Valve#503
minimal_valve_position parameter for Shelly Valve#503Conversation
minimum_valve_position parameter for Shelly Valveminimal_valve_position parameter for Shelly Valve
|
I'd suggest the following formula if for any reason the valve goes below the minimal pos: Is this the same minimal_valve_position parameter, that was already supported ? I mean this update will not introduce the Minimal Valve Postition to Report Open parameter? |
|
Honestly, I don't like this change, we have to add an additional parameter, which is actually available but in a different payload. This is just stupid. That's why I opened a feature request to add |
|
I totally understand you and if it is not a critical issue, you can cancel my request. minimal_valve_position itself was already mapped in your code and this is why I thought about stepping further. But I didn't see the issues coming from different payloads. |
|
No response from Shelly team so I will merge this change. |
Closes #498