Add type-checking using mypy#46
Merged
effigies merged 20 commits intobids-standard:mainfrom Nov 26, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #46 +/- ##
==========================================
- Coverage 90.95% 90.36% -0.60%
==========================================
Files 12 13 +1
Lines 774 799 +25
Branches 116 120 +4
==========================================
+ Hits 704 722 +18
- Misses 46 49 +3
- Partials 24 28 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a8f1548 to
1ce2b4f
Compare
8a639e6 to
7b6ed10
Compare
Collaborator
Author
|
@effigies Here's an initial attempt at adding type-checking using |
Contributor
|
Yup, this looks good to me. Now to start fixing the errors... I may push a few things. |
=== Do not change lines below ===
{
"chain": [],
"cmd": "uv lock",
"exit": 0,
"extra_inputs": [],
"inputs": [
"pyproject.toml",
"uv.lock"
],
"outputs": [
"uv.lock"
],
"pwd": "."
}
^^^ Do not change lines above ^^^
Contributor
|
Reenabling strict mode and some initial fixes... |
ubdbra001
commented
Nov 26, 2025
Collaborator
Author
ubdbra001
left a comment
There was a problem hiding this comment.
Had a look and am happy with what you've done.
Merge away!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #43
Adds type-checking using
mypyto the CI withtox.