Fix test for MNE-Python main#127
Merged
sappelhoff merged 3 commits intobids-standard:mainfrom Feb 18, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #127 +/- ##
=======================================
Coverage 99.31% 99.31%
=======================================
Files 2 2
Lines 293 293
=======================================
Hits 291 291
Misses 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
I added |
sappelhoff
reviewed
Feb 18, 2025
Member
sappelhoff
left a comment
There was a problem hiding this comment.
ok with me to add "packaging" to the test deps, however something still seems to be off according to the CI.
Collaborator
Author
|
@sappelhoff all green now! |
sappelhoff
approved these changes
Feb 18, 2025
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MNE-Python now discards the first "New Segment" annotation automatically, since it only contains the recording time (see mne-tools/mne-python#13100).