RF: Add extension_initial_dot config option to transition to extension entity with initial dot#629
Conversation
effigies
left a comment
There was a problem hiding this comment.
Couple quick notes. Awkward name, so happy to change it if there's a better one.
| "this warning and include the leading dot, use " | ||
| "`bids.config.set_option('extension_initial_dot', True)`.", | ||
| FutureWarning) | ||
| config = "bids-nodot" |
There was a problem hiding this comment.
This is where the warning is emitted. It's called with every new layout.
| if new_pattern != old_pattern: | ||
| warnings.warn( | ||
| "Cannot modify extension_initial_dot option after initialization. " | ||
| "Set option immediately after ``import bids``.") |
There was a problem hiding this comment.
I'm not entirely positive how to reach this...
|
|
||
| run = dataset.create_node('run', entities, image_file=img_f, | ||
| duration=duration, repetition_time=tr) | ||
| run_info = run.get_info() |
There was a problem hiding this comment.
Tal, I'm not sure how these changes hit this code path, but we were returning a RunNode sometimes in a function that is always supposed to return a NodeIndex. I'm assuming it's a refactoring artifact, but I haven't dug through the git-blame.
Codecov Report
@@ Coverage Diff @@
## master #629 +/- ##
==========================================
+ Coverage 83.91% 83.93% +0.01%
==========================================
Files 26 26
Lines 3252 3274 +22
Branches 826 836 +10
==========================================
+ Hits 2729 2748 +19
- Misses 334 336 +2
- Partials 189 190 +1
Continue to review full report at Codecov.
|
|
Bumping on this. It would be nice to finally release 0.11, and I figured we might as well have a planned breaking change started sooner than later. |
|
Tests are passing and the only coverage missing is a hard (impoosible?) to reach edge case. I'm boing to go ahead with this and release. We can roll back in 0.11.1 if I've catastrophically miscalculated. |
Fixes #618.
cc @tyarkoni @yarikoptic