Skip to content

MAINT: Add .zenodo.json#308

Merged
effigies merged 24 commits intobids-standard:masterfrom
effigies:maint/zenodo
Dec 12, 2018
Merged

MAINT: Add .zenodo.json#308
effigies merged 24 commits intobids-standard:masterfrom
effigies:maint/zenodo

Conversation

@effigies
Copy link
Copy Markdown
Collaborator

@effigies effigies commented Nov 28, 2018

Todo:

  • "Last, First M." format for names
  • Get all affiliations, ORCIDs, preferred spellings
  • Add additional .zenodo fields

Closes #299.

Copy link
Copy Markdown
Collaborator Author

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To update your entry, you should specify the desired spelling of your name in the .mailmap, along with any name/email combinations you expect to appear in your commits. You can see how it currently looks with git shortlog -nse.

Additionally, use GitHub's suggestion feature to add your affiliation and/or ORCID.

Alejandro de la Vega <delavega@utexas.edu> delavega4 <aleph4@gmail.com>
Alejandro de la Vega <delavega@utexas.edu> Alejandro de la Vega <aleph4@gmail.com>
Christopher J. Markiewicz <markiewicz@stanford.edu> Chris Markiewicz <effigies@gmail.com>
Christopher J. Markiewicz <markiewicz@stanford.edu> Chris Markiewicz <markiewicz@stanford.edu>
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use this line as an example for declaring how you would like your name to appear in citations.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just to clarify, if my commit-name coincides with my true name, I don't need to add myself here, right?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. Unless you want to add a middle initial or anything, you don't need to do anything here.

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 28, 2018

Codecov Report

Merging #308 into master will decrease coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #308      +/-   ##
==========================================
- Coverage   73.03%   72.84%   -0.19%     
==========================================
  Files          24       24              
  Lines        2551     2563      +12     
  Branches      624      630       +6     
==========================================
+ Hits         1863     1867       +4     
- Misses        506      513       +7     
- Partials      182      183       +1
Flag Coverage Δ
#unittests 72.84% <ø> (-0.19%) ⬇️
Impacted Files Coverage Δ
bids/layout/layout.py 73.55% <0%> (-1.92%) ⬇️
bids/config.py 75.6% <0%> (+3.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd9ac08...a0b94ba. Read the comment docs.

effigies and others added 2 commits November 28, 2018 15:34
gkiar and others added 2 commits November 29, 2018 09:45
Co-Authored-By: effigies <effigies@gmail.com>
@effigies effigies added this to the 0.7.0 release milestone Nov 29, 2018
Copy link
Copy Markdown
Collaborator Author

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pinging everybody who hasn't otherwise commented. If you could take a second to confirm or suggest changes to your entries, I'd appreciate it. Specifically, please verify that your name and affiliation are how you would like them to appear on a publication, and that your ORCID is correct, if you have one.

effigies and others added 3 commits November 30, 2018 09:20
Co-Authored-By: effigies <effigies@gmail.com>
Co-Authored-By: effigies <effigies@gmail.com>
@tyarkoni
Copy link
Copy Markdown
Collaborator

It just occurred to me that we should probably include folks who contributed to grabbit but not pybids. Is it feasible to integrate the grabbit contributor list, or should we add those folks manually? Sorry, I should have thought of this earlier...

@effigies
Copy link
Copy Markdown
Collaborator Author

effigies commented Dec 1, 2018

Yeah, we can add them. Probably makes the most sense to run from the latest tag?

Copy link
Copy Markdown
Collaborator Author

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just another round of pings for people to check I've gotten their information right/request more information. Thanks to those who've already responded, and sorry for the noise.

{
"affiliation": "McGill University",
"name": "Poline, Jean-Baptiste",
"orcid": "0000-0002-9794-749X"
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jbpoline Let me know if you want a different affiliation. Pretty sure I got your ORCID right.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@effigies thanks for adding my info. I'm affiliated with the University of Oregon & my ORCID is: 0000-0002-3959-9060

"orcid": "0000-0003-3456-2493"
},
{
"name": "Petrov, Dmitry"
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lodurality This was the best affiliation I was able to find. Let me know if it's incorrect/you prefer another. I also could not find an ORCID.

{
"affiliation": "Sainte-Anne Hospital Center, Universit\u00e9 Paris Descartes",
"name": "Roca, Pauline",
"orcid": "0000-0003-2089-6636"
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PaulineRoca Can you verify/correct your affiliation (\u00e9 will render as é)?

{
"affiliation": "Department of Psychology, Stanford University",
"name": "Esteban, Oscar",
"orcid": "0000-0001-8435-6191"
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oesteban I'll also assume this is fine for you if I don't hear from you.

@yarikoptic
Copy link
Copy Markdown
Collaborator

Just want to thank you @effigies for doing this so meticulously!

@choldgraf
Copy link
Copy Markdown
Contributor

Hey all - I'd like to cite this in the BIDS-iEEG preprint...any timeline on when this PR will land?

@effigies
Copy link
Copy Markdown
Collaborator Author

@choldgraf This PR can land pretty much any time (though there are some non-responses, which means I might need to remove affiliations I'm not positive of), but the bigger problem is that we're not sure when the next release will hit.

@tyarkoni @adelavega Thoughts? If we cut 0.7.0 this week, I think we'd have to be ready for a lot of bug reports and 0.7.1 next week.

@choldgraf
Copy link
Copy Markdown
Contributor

Cool - well FWIW we'll submit the psyrxiv version on Thursday most likely, so I'll cite the DOI or the URL of this repo depending on whether the DOI exists or not!

@effigies
Copy link
Copy Markdown
Collaborator Author

effigies commented Dec 11, 2018

Okay. Well I think this is mergeable. @tyarkoni Care to review?

We're missing confirmations/corrections from the following:

I am reasonably confident that they all at least at one time held the affiliations I've filled in for them. The main other thing to check is whether we want to add other metadata.

@tyarkoni
Copy link
Copy Markdown
Collaborator

LGTM, though I didn't go through the prep_zenodo.py script in detail (and don't feel a need to).

Assuming that Zenodo generates a new version for every release, I don't think it matters much when the next release happens. If one or two people's info is wrong for a few weeks/months, we can live with that.

Thanks!

@effigies effigies merged commit 5d702d7 into bids-standard:master Dec 12, 2018
@effigies
Copy link
Copy Markdown
Collaborator Author

effigies commented Dec 12, 2018

tools/prep_zenodo.py should be run and any changes inspected and committed before a release.

@effigies effigies deleted the maint/zenodo branch December 12, 2018 14:04
@choldgraf
Copy link
Copy Markdown
Contributor

does anybody know how to import a zenodo ref from a github repo into zotero?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.