Nice. This looks good to me. Two minor things.

Any of the process.nextTick calls that take a generic async callback don't need the extra anonymous function.

For example this

process.nextTick(function() { cb() });

could be written as this

process.nextTick(cb);

And lastly, for the current npm publishing work flow to work you'll need to up the version number in the package.json file.

Thanks for the PR.

Thanks!
I submitted a new commit taking into account your suggestions.

Oh.. I actually meant the version of the bids validator needs to be changed. So in package.json the version property (line 3) needs to be changed.

{
	"name": "bids-validator",
	"version": "0.20.0",
	"description": "",
	"main": "index.js",
	"repository": {
		"type": "git",
		"url": "https://github.com/INCF/bids-validator.git"
	},
	...
}

Probably a "minor" version bump.

{
	"name": "bids-validator",
	"version": "0.21.0",
	"description": "",
	"main": "index.js",
	"repository": {
		"type": "git",
		"url": "https://github.com/INCF/bids-validator.git"
	},
	...
}

The dependency version updates are probably still a good thing though and it looks like tests are still passing with them.

OK

Is this ready to merge?

For me yes: it is working, and it solved the issues that I encountered with a big number of files.

As you want but I think this issue is outdated because I just tested the browser version and it worked.
You can check on your side, modify my pull request (I think it can possibly work just with the async limit, anyway it is better with it), or reject it.

@ntraut Thanks for testing this in the browser. I just dug into the issue a little deeper and it looks like browserify (a part of our web build flow) automatically shims process.nextTick() during the build process.

So @chrisfilo I'm good with these changes now with the caveat that this means the validator will continue to work in our applications and in node, but anyone else using it in the browser will need to make sure they have a shim for process.nextTick() in place.

We could also build a shim into the validator.

Thanks for looking into this.

Wouldn't everyone use browserify before trying to use it in the browser? By saying our applications do you also include "http://incf.github.io/bids-validator"?

Yea by "our applications" I mean the gh-pages and the crn_app repo. There are a number of ways to bundle a library like this for the web, but yes most will likely include shims for various node specifics by default. I just checked and webpack also includes a shim.